search

minetest / irrlicht

Minetest's fork of Irrlicht
Other
114 stars 87 forks source link

CFileSystem: Fix signed integer conversion on MinGW #291

Closed SmallJoker closed 7 months ago

SmallJoker commented 7 months ago

Fixes https://github.com/minetest/minetest/issues/14381

How to test:

  1. Reproduce the crash (on Windows or Wine)
  2. After the buildbot of this PR finished compiling, do check its "Artifacts" section and overwrite the IrrlichtMt.dll file of a comparably recent Minetest buildbot artifact.
  3. Crash no longer happens
  4. ???
  5. Profit
SmallJoker commented 7 months ago

Retested the uintptr_t to intptr_t change and can confirm it still works.

SmallJoker commented 7 months ago

FYI @mzeilfelder Although I did not test upstream Irrlicht yet, it is likely that the file picker dialogue will show the same crash issue on 64-bit MinGW builds. Letting you know in case there's already such issues reported.

mzeilfelder commented 7 months ago

Thanks, but upstream still using 'long' so it's fine.