Readd all media formats

minetest / irrlicht

Minetest's fork of Irrlicht

Other

114 stars 87 forks source link

Readd all media formats #65

Closed appgurueu closed 3 years ago

appgurueu commented 3 years ago

They shouldn't have been removed in the first place; their removal breaks Minetest's backwards compatibility. Keeping the readers around is not too much of a hassle in terms of added compile time and code base size.

sfan5 commented 3 years ago

Adding "all" formats back does not make in the first place because that would include PVR, DDS, HalfLife (whatever that is) and LMP which Minetest has never allowed the use of.

For the rest (TGA, PSD, PCX, WAL, PPM, RGB) ask yourself this:

Which programs can write this format today?
Can Irrlicht even read a file exported today? (<- PSD?)
Is the format primitive (e.g. no compression support)? In which case there is either no reason to use it (for existing media) or BMP is a suitable alternative (for dynamic generation).
Does this format have any use in mods/games we know of?

appgurueu commented 3 years ago

I mostly want MD2 back, because it offers features B3D and X do not have - hecks already noted that. I don't really care about (actually) redundant formats I don't use.

sfan5 commented 3 years ago

What are those features? Animations?

appgurueu commented 3 years ago

What are those features? Animations?

Yes

sfan5 commented 3 years ago

B3D and X both(?) do that too so there must be another reason why you prefer MD2...

appgurueu commented 3 years ago

B3D and X both(?) do that too so there must be another reason why you prefer MD2...

Well, MD2 animations are a different breed. Not to mention that I don't trust B3D and X animations...

wsor4035 commented 3 years ago

MD2: https://github.com/minetest/irrlicht/pull/48#issuecomment-919343927