Hide mapgen v6 in mapgen selection dropdown

[paramat]

I see a lot of players reporting missing features in mapgen v6, and i spend a lot of time explaining that it has hardcoded biomes, fewer biomes, less variety of flora, doesn't use the Biome API etc. Then i feel bad that they started a world in such an unimpressive mapgen.

Although of course (unfortunately) we have to support mapgen v6 worlds (i would love remove mapgen v6, it is a pain), it is so much poorer than the other mapgens i think we should encourage newer players to avoid it. This can be done using the ability to hide mapgens from the mapgen selection dropdown.

[Desour]

Can't the dropdown entry just be renamed to something like v6 (old)?

[paramat]

The dropdown can only display the raw mapgen names currently, so displaying extra mapgen info will need to be coded. The advantage of hiding is that it is simple, requires no coding, and is more discouraging for everyone, which is the whole idea, i do not want mgv6 to be easily selectable, which it will be with your suggestion. I do not want it to appear as valid as the other mapgens.

I really want to remove mgv6, but i cannot, so this is the minimum that would satisfy me =)

[ghost]

The dropdown can only display the raw mapgen names currently

So this is something to work on 😄 This would finally allow proper mapgen names.

Oh, and yes: Remove incompatible or unwanted mapgens. This is what the function was implemented for.

[paramat]

I meant that referring to the request for mapgen info to be displayed beside each, not to display new mapgen names. The 'raw mapgen names' are the proper names, they're not engine terminology.

[Moth-Tolias]

if you do decide to hide v6, hiding the "empty node" one sounds like a good idea as well. took me a while to realise that the reason i was continually falling into the void was actually that i had accidentally set it as such rather than that the game was bugged.

[MarkuBu]

I just want to mention that some games like Voxelgarden recommend v6

[paramat]

'singlenode' used to be hidden for that reason but was unhidden later, see #5867 #5868

[paramat]

Changed my mind because https://github.com/minetest/minetest/pull/5868#issuecomment-305422692

"Some mods select options depending on mapgen, but singlenode has to be enabled by a mod and that mod may be loaded after the mod that detects mapgen. This resulted in Nyan Cats appearing in singlenode even though they were not meant to, because default loaded before any mod that enables singlenode. In this way re-adding it to menu will help."

I agree it's better to add some in-game mapgen info to warn, as already requested.

EDIT: If v6 was hidden from the mapgen selection dropdown, the only way to enable it would be using an optional mod added to a game. The problem is that this optional mod runs after game mods (unless the game mods have their dependencies edited, which is non-trivial), and game mods may need to correctly detect mapgen (MTG does in mapgen.lua). Overall this makes hiding v6 from the dropdown significantly problematic.

[ghost]

Nyan Cats don't show up at all anymore since a few years.

[paramat]

LOL yes good point =) It was just an example of the sort of problem that can happen.

Here's a simple thing that might help for now: I could move v6 to the bottom of the mapgen selection list.