search

minetest / minetest_game

Minetest Game - A lightweight and well-maintained base for modding [https://github.com/minetest/minetest/]
http://minetest.net/
Other
1.41k stars 567 forks source link

"Fix" of Ukrainian localisation #3070

Closed EGYT5453 closed 7 months ago

EGYT5453 commented 7 months ago

This PR "fixes" Ukrainian l10n, so it will be much better than before! Hooray! Related issue: https://github.com/minetest/minetest_game/issues/3063

appgurueu commented 7 months ago

Thanks for the review(s) Monte.

EGYT5453 commented 7 months ago

In your place, I would not trust a person who speaks Russian to check the Ukrainian translation.

alwayshopeless commented 7 months ago

In your place, I would not trust a person who speaks Russian to check the Ukrainian translation.

Meanwhile, Russian-speaking Ukrainians: exists

EGYT5453 commented 7 months ago

Meanwhile, Russian-speaking Ukrainians: exists

Unfortunately :^(

MoNTE48 commented 7 months ago

Meanwhile, Russian-speaking Ukrainians: exists

Unfortunately :^(

This horrible war has opened up so many social problems in Ukraine that I have never encountered in Russia or Europe. 😕 A great demonstration of my country's complete unwillingness to be part of something bigger (like 🇪🇺 membership), to my horrible heart ache! I've never encountered such nationalism and claims about my family's language anywhere but my homeland. 🥲👎

EGYT5453 commented 7 months ago

Almost ready! Has anyone found something else that can be improved?

EGYT5453 commented 7 months ago

That's it?

appgurueu commented 7 months ago

@sfan5 does the two-approval rule also apply to translation PRs? It wouldn't seem very useful, given that both of us don't speak Ukrainian (best I could do is churn this through an online translator to verify that it roughly matches).

appgurueu commented 7 months ago

Decided to count @alwayshopeless's approval. It carries more weight than my approval, after all.