Log bucket liquid placement

minetest / minetest_game

Minetest Game - A lightweight and well-maintained base for modding [https://github.com/minetest/minetest/]

http://minetest.net/

Other

1.41k stars 567 forks source link

Closed Emojigit closed 1 month ago

Emojigit commented 2 months ago

This PR adds code to log liquid placements done via buckets. Previously, only failed attempts were logged.

This PR is ready for review.

Emojigit commented 1 month ago

Reordering the parameters to be in the order the message is built (roughly " did at ") could also help make this slightly more readable IMO.

I kept the order mostly for consistency with the check_protection function above.

(Why log picking up liquids though?)

Like the engine log digging node, IMO logging this is also needed.