minetest / minetest_game

Minetest Game - A lightweight and well-maintained base for modding [https://github.com/minetest/minetest/]
http://minetest.net/
Other
1.43k stars 578 forks source link

Cotton needs a new texture (it looks like string) #404

Closed davisonio closed 7 years ago

davisonio commented 9 years ago

At the moment cotton looks like string rather than cotton. Probably because little while back, farming_string.png was renamed to farming_cotton.png in https://github.com/minetest/minetest_game/commit/60ccb522.

p5yg3n commented 9 years ago

If the texture is changed should the recipe be changed as well? Should we be able to craft cotton into string or should we eliminate string all together?

C1ffisme commented 9 years ago

Bump.

I agree with MT-Modder, should string be eliminated, or cotton be made into string? If we do the first option, we save making a pointless item and making mods lose a lot of support if we rename the string. If we do the latter, we make a useless item, but it's more realistic and keeps mod support.

Now that I've bumped this, we'll see what other devs think.

VOTE:

p5yg3n commented 9 years ago

I vote we make cotton craft into 2 strings since it keeps mod compatibility and makes crafting wool a little bit easier. (I'm not saying it's hard to craft though)

C1ffisme commented 9 years ago

Ok, but what do we use cotton for, a decorative item? Fuel?

p5yg3n commented 9 years ago

It would be just like wheat is to flour, or flour is to bread. A middle-man. Most craftitems are.

C1ffisme commented 9 years ago

@MT-Modder True, but flour is an ingredient for many cooking mods, and wheat makes straw. Cotton could make... What? There isn't much use for it.

p5yg3n commented 9 years ago

Well maybe somewhere down the line they could add a clothing mod, i.e. 3d_armor. The only use for cotton is wool so... Regarding only minetest_game and no other mods the only use for flour is bread so the same would go for string.

This setup looks good to me.

C1ffisme commented 9 years ago

True, true.

Echoes91 commented 9 years ago

My enhanced throwing mod relies a lot on strings for bows, same for other mods stuff like ropes. Losing string would require to define a new craftitem for each mod, which are going to be incompatible unless we define a new unique group etc. What's still quite hard to imagine is how does cotton become wool...

paramat commented 8 years ago

Cottonwool! :] Our wool is synthetic vegan wool made from cotton. I like the idea of crafting cotton into string or cotton into wool. Like 3 cotton in a horizontal line = string. 4 or 9 in a square = wool.

0-afflatus commented 8 years ago

I don't have a huge opinion on this - I do something very similar on grailtest. I have replaced cotton with plant fibre, but it's essentially the same thing; that can be crafted into string and 'wool', that is fabric. I do a 1 to 1 conversion from plant fibre to string and 9 into wool. (String can also be crafted in to rope). Adopting this sort of approach in MTG using cotton would be a Good Thing.

paramat commented 8 years ago

There is already a string-cotton alias in farming mod so maybe the 2 were seperate in the past.

0-afflatus commented 8 years ago

Is that because the full grown cotton in farming mod used to drop farming:string instead of farming:cotton? And you could craft wool out of 4 string. It's a mess and they could do with separating out again.

Ferk commented 8 years ago

Can't wool be renamed to fabric or cloth? I don't think Minetest needs to mimic every single Minecraft block, specially when doing that requires confusing recipes

C1ffisme commented 8 years ago

I agree with @Ferk. Cottonwool is a bit silly, and the transformation from cotton into wool is unrealistic, even for Minetest Game.

paramat commented 8 years ago

I feel that cotton plants should drop cotton which looks like cotton, then this is crafted into either string or wool. But how to cope with breakage and aliases?

rubenwardy commented 7 years ago

I feel that cotton plants should drop cotton which looks like cotton, then this is crafted into either string or wool

Agreed

But how to cope with breakage and aliases?

You'd only be adding farming:string then changing craft recipes. The only breakage would be balance related - players would lose value if they have cotton in one of their inventories as cotton loses value. I think this is fine - note it was done for TNT as well previously

Napiophelios commented 7 years ago

I think cotton should basically remain the same as it is now (except a new texture); string would just be a smaller derivative of cotton used for lesser recipes

That way cotton wouldn't lose any value.

1wool= 4 cotton 1cotton= 9strings

edit: what you guys think of something like this for cotton

20170105084942

farming_cotton

rubenwardy commented 7 years ago

Looks good. In all those images they are made up of a collection of balls - 3/4 - please may see what it looks like if you try and emphasis that? The single ball looks quite large

Napiophelios commented 7 years ago

Rough draft :)

sofar commented 7 years ago

The cotton texture looks fantastic. It would be nice though to get some direct use out of cotton as well, somehow. If it's purely ever only used to make wool, that would not be preferable.

paramat commented 7 years ago

Texture is good. I certainly support sorting out this cotton/string crafting mess.

Napiophelios commented 7 years ago

By itself, it looks like a flower, but it looks kinda nice in the game. sample

farming_cotton_large farming_cotton

sofar commented 7 years ago

not as good. I don't recognize the cotton ball that I envisioned.

Napiophelios commented 7 years ago

yeah its hard to get 4 of them in there like Ruben wants and not look like a blob :( I prefer the first one myself.

GreenXenith commented 7 years ago

Wouldn't adding real cotton and changing the current one to string break tons of mods?

rubenwardy commented 7 years ago

Ok, I like the first one

paramat commented 7 years ago

I prefer the first one, maybe it could be reshaped to suggest the 4 balls of cotton?

tobyplowy commented 7 years ago

@Napiophelios +1

paramat commented 7 years ago

I think we should sort this mess out, even if it means a little breakage.

I like the idea of crafting cotton into string or cotton into wool. Like 3 cotton in a horizontal line = string. 4 or 9 in a square = wool.

Either texture is ok for me.

TumeniNodes commented 7 years ago

This issue started around 2 years ago, and has sat for 5 months since the last communication, with a good replacement texture. The current farming_cotton.png could be used as farming_string.png? What would need to be done to either get this done or close it? Just asking

paramat commented 7 years ago

Needs some consideration about how to minimise breakage, but i would also like to sort this out, and separate cotton from string. Now would be a good time if there is any breakage, at least these are items not nodes so not a big problem. Perhaps i'll just make a PR then we can look at breakage together.

TumeniNodes commented 7 years ago

sounds good

paramat commented 7 years ago

@Napiophelios is CC BY-SA 3.0 ok for your texture? I'm using the first one in a PR.

paramat commented 7 years ago

PR #1876

Napiophelios commented 7 years ago

Yep. CC BY-SA 3.0 , that's what I usually use for textures.

paramat commented 7 years ago

1876 merged.