Detect geo of server. - Githubissues

minetest / serverlist

The global Minetest server list server

GNU Lesser General Public License v2.1

50 stars 28 forks source link

Detect geo of server. #29

Closed sofar closed 5 years ago

sofar commented 5 years ago

Using geolite2, we attempt to detect the continent of the server and store the 'continent code' in the serverlist. This is reasonably broad enough to help players in the client find truly "nearby" server.

The client will have to be changed to select a continent to change orderign or filtering.

ghost commented 5 years ago

Good , better then nothing, best is still client might make own ping, as solved ALL problems. I will see how it will work, as have no idea how it will be implemented ... as there is always a gap between wish and reality :-)

sofar commented 5 years ago

I think I've mentioned it before, but I think it would be too costly for each MT client to ping each MT server. This would effectively mean millions of ping packets on a time scale well under an hour. I do not think that that is a scalable solution, and I therefore do not support such an implementation.

sofar commented 5 years ago

Updated:

added requirements.txt line
exception only handles the core geolite2 exception
warnings are a bit more detailed
still fairly fault tolerant as is

Seems a little bit cleaner now as well.

sfan5 commented 5 years ago

Merged. 772fc29cb89ccd0052a64a8a9caf7cb4e8f481e9