minetoblend / osu-cad

https://osucad.com
39 stars 5 forks source link

Feat: Compress beatmap backgrounds into thumbnails #45

Closed minetoblend closed 8 months ago

minetoblend commented 8 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The changes primarily focus on enhancing the beatmap functionality within the application. This includes adding new properties to beatmap and room information types, refining the asset management process, and introducing a sophisticated system for handling beatmap thumbnails through processing jobs. Additionally, there's an emphasis on improving the infrastructure with the addition of modules for task scheduling and Redis-based job management, alongside securing access to administrative features.

Changes

File(s) Summary
Dockerfile Adds sharp package installation in @osucad/server workspace using yarn.
.../src/components/beatmap/MapsetCard.vue Updates cover URL retrieval to use thumbnailSmall instead of background.
.../src/types/beatmap.ts, .../src/types/roomInfo.ts Makes thumbnailSmall and thumbnailLarge optional/nullable in beatmap types; changes thumbnail in room info to be required or null.
.../src/admin/admin.controller.ts, .../src/beatmap/beatmap.controller.ts, .../src/beatmap/mapset.controller.ts Updates thumbnail link logic based on thumbnailSmall and adjusts logic for importing and finding mapsets.
.../src/app.module.ts Adds imports and configurations for BullModule, ScheduleModule, BullBoardModule, ExpressAdapter, and BullboardAuthMiddleware.
.../src/assets/assets.service.ts Refactors asset handling with new methods for managing asset operations.
.../src/beatmap/beatmap-import.service.ts, .../src/beatmap/beatmap-thumbnail.processor.ts, .../src/beatmap/beatmap.service.ts Enhances beatmap import and thumbnail processing with TypeORM, NestJS injections, and new operations. Adds thumbnailQueue for processing thumbnail jobs in BeatmapService.
.../src/beatmap/beatmap.entity.ts, .../src/beatmap/mapset.entity.ts Adds needsThumbnail, thumbnailLarge, and thumbnailSmall properties; updates getInfo method to include thumbnail URLs.
.../src/beatmap/beatmap.module.ts Integrates BeatmapThumbnailProcessor with Bull queue and BullBoard for thumbnail processing.
.../src/bullboard-auth.middleware.ts Introduces BullboardAuthMiddleware to check admin status for requests.
.../src/tasks/migrations/1708971421003-beatmap-thumbnails.ts Adds migration for thumbnail-related fields in the beatmaps database table.

🐰✨

In a land of code and binary streams,
A rabbit hopped, chasing digital dreams.
With each commit, a new feature blooms,
Among the bytes, its excitement looms.
"To the beatmaps!" it joyously screams.
πŸŒŸπŸ“¦πŸŽΆ

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.