minetoblend / osu-cad

https://osucad.com
39 stars 5 forks source link

Feature/presign links directly #46

Closed minetoblend closed 8 months ago

minetoblend commented 8 months ago

Now sending presigned links directly instead of relying on redirects. Also added caching cuz presigning takes a while.

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The update involves enhancing components, refining data structures, and optimizing asset management across the client and server packages. New components are introduced, data access patterns are streamlined, and global caching is implemented for efficient asset retrieval. The transformation of beatmap entities to information objects is now handled by dedicated transformers, improving clarity and maintainability.

Changes

Files Change Summary
packages/client/components.d.ts Added BeatmapAccessRequestDialog, NotificationsDropdown components.
.../client/src/components/beatmap/MapsetCard.vue Removed optional chaining for thumbnailSmall, edit properties.
.../client/src/editor/components/ShareDialog.vue Updated shareUrl construction by removing .href.
packages/common/src/types/beatmap.ts Simplified links in MapsetInfo and BeatmapInfo interfaces.
packages/server/src/admin/admin.controller.ts Added assetsService for async room data processing.
packages/server/src/admin/admin.module.ts, .../src/app.module.ts Imported AssetsModule, CacheModule respectively.
packages/server/src/assets/assets.service.ts Injected CACHE_MANAGER for caching S3 assets.
.../server/src/beatmap/beatmap.controller.ts,
.../mapset.controller.ts
Added transformers, replaced getInfo() with transformer methods.
.../server/src/beatmap/beatmap.entity.ts,
.../mapset.entity.ts
Removed getInfo() method, updated shareId generation, removed MapsetInfo usage.
.../server/src/beatmap/beatmap.module.ts Added MapsetTransformer, BeatmapTransformer services.
.../server/src/beatmap/beatmapTransformer.ts,
.../mapset.transformer.ts
Introduced methods to transform entities into information objects.

"In the world of code and bits, where rabbits hop and logic fits,
🌟 Changes bloom like spring's first light, enhancing features, making bright.
With transformers sleek and caching swift,
Across the land, our spirits lift.
🐰 So here's a cheer from CodeRabbit's heart,
For every change, a brand new start!"
🚀🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.