search

ming-codes / ember-cli-d3

An ember-cli addon to provide D3 integration into Ember app.
MIT License
43 stars 18 forks source link

Fix urlRefShim to pass through correct number of arguments #59

Closed nagirrab closed 8 years ago

nagirrab commented 8 years ago

Hi,

I noticed a problem with the url shim - if you call e.g. selection.style("cursor") as an accessor, this gets translated by the shim into selection.style("cursor", null) which then actually modifies the value.

This particularly causes problems for the brush examples - the cursor styles disappear.

This should fix it - let me know if you need any more tests/explanation, etc.

Thanks for the project!

ming-codes commented 8 years ago

Looks good! Thanks for the PR!

I'll write some test cases to cover this.