nus-se-bot
commented
6 months ago Team's Response
Our app only has duplicate detection in adding/editting of Categories within a Person, but not checking of duplicate persons themselves. In a gaming scenario, it is very likely that there can be many people or characters with the same name. Adding a duplicate restriction would thus be unintuitive in the nature of our app. It is up to the user to add differentiating features such as tags or descriptions , since they already have the creative freedom to do so, before being able to find them using our find feature.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Allowing adding of the same person
[original: nus-cs2103-AY2324S2/pe-interim#78] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
It was explicitly stated in the UG that people with the same name is not considered a duplicate, evene if they have the same tags and categories and descriptions. This was an explicit design choice for user freedom due to the fact that there can easily characters with the same name in multiple games or in the same game. Many people in real life also have the same name, and rarely give their full name to other fellow gamers for their contact, so many gamers may only know each other by first name basis.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: My issue is not with duplicate names, but rather with duplicate instances, where there is no way in the app to distinguish between two instances with the exact same name, same category, same tag and same description.
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I disagree as the app does not distinguish between duplicate entries with identical names and details. As per my bug report, there were exactly three instances with the same name, same category, same tag and other info related to a `Dragon instance`. **Expected Result** The app should have a way to uniquely identify each instance, even if their visible details are all the same. **Actual Result** The app treats both instances as identical, making it impossible to select one over the other in forming a group.
Description: It's a bit unclear of what is considered a duplicate in the UG. The following two contacts with the exact name, categories and tag are very likely a duplicate with no way to distinguish them, hence I categorise as a duplicate detection according to the Admin tP.
Steps to reproduce:
Expected An error message forbidding the creation of the exact same instance.
Actually As shown in the image above, two contacts with the exact same details are accepted and could not be differentiated.