search

minghuaw / fe2o3-amqp

A rust implementation of the AMQP1.0 protocol based on serde and tokio.
MIT License
58 stars 7 forks source link

`serde_amqp::Value` variants not following rust naming convention #206

Closed minghuaw closed 9 months ago

minghuaw commented 1 year ago

Due to my negligence, the variant names didn't strictly follow the rust naming convention, for example, Value::UInt should be Value::Uint instead. Fixing this would be a breaking change and is probably not worth it.

This issue is opened just for record.

minghuaw commented 9 months ago

In UpperCamelCase, acronyms and contractions of compound words count as one word: use Uuid rather than UUID, Usize rather than USize or Stdin rather than StdIn.

https://rust-lang.github.io/api-guidelines/naming.html

minghuaw commented 9 months ago

Fixed in 40856960227dbe914d2d989b5520dc68f2785042