search

minghuaw / fe2o3-amqp

A rust implementation of the AMQP1.0 protocol based on serde and tokio.
MIT License
58 stars 7 forks source link

Fixed spelling error in Session and SessionAcceptor (widnow->window). #242

Closed LarryOsterman closed 2 months ago

LarryOsterman commented 2 months ago

Note: This is a breaking change, so added an Unreleased changelog entry to reference the change.

minghuaw commented 2 months ago

We could make this non-breaking by adding outgoing_window and mark the original outgoing_widnow as deprecated. What do you think? Or we could make it a breaking release (likely 0.11)

minghuaw commented 2 months ago

Found other minor problem that would result in a breaking change. So I guess we could make this a breaking change anyway

LarryOsterman commented 2 months ago

We could make this non-breaking by adding outgoing_window and mark the original outgoing_widnow as deprecated. What do you think? Or we could make it a breaking release (likely 0.11)

I am good either way, tbh. I do like the non-breaking aspect. But if there's another issue, so be it.

Thanks for the quick turnaround.