search

mingo-app / mingo

Found a bug? have a FR ?
60 stars 2 forks source link

Keyboard shortcuts for next/previous tab #440

Open brianlukoff opened 2 years ago

brianlukoff commented 2 years ago

From muscle memory I keep wanting to press Cmd+Shift+[ to move to the previous tab or Cmd+Shift+] to move to the next tab. Is it possible to add those keyboard shortcuts?

tothradoslav commented 2 years ago

sure, ready

brianlukoff commented 2 years ago

Thanks!

tothradoslav commented 2 years ago

Hi, we have uploaded a new release candidate with this issue corrected in it. Please check it out and let me know if it works fine. Thank you for your input!

https://github.com/mingo-app/mingo/releases/tag/v1.9.1-rc1

sagrawal31 commented 1 year ago

I have a different view on the keyboard shortcut for the next/previous tab. Since major browsers (Chrome, Safari, Firefox), hybrid & native apps (like Canva, Miro, Notion, Apple freeform and many more), and IDEs (example: IntelliJ, TextMate) use a common keyboard shortcut i.e. Ctrl + Tab for next tab and Ctrl + Shift + Tab for previous tab, it would be seamless to support those shortcuts in Mingo as well.

Would like to reopen this issue.

tothradoslav commented 1 year ago

CTRL + tab works for toggling the previous tab. This is how I see it working in intelliJ, for example. This is, i guess, a fairly subjective issue, as for me, the behaviour in Chrome, for example, is annoying :)

sagrawal31 commented 1 year ago

Okay, it's an opinionated choice. Truly your decision!

sagrawal31 commented 9 months ago

By the way, the existing shortcuts (to navigate) are still useless conditionally. Pressing ⌘LEFT or ⌘RIGHT does not work when the input field is focused either in Document, Aggregation or NodeShell tabs, so I have to first blur the input fields with the mouse and then use the shortcuts to change the tab so shortcuts are of no use because the primary use of Mingo is to query data so 70% of the times, an input field will have the focus.

https://github.com/mingo-app/mingo/assets/1804514/a079008e-e9f9-4765-a504-4b64ca732eef

sagrawal31 commented 2 months ago

@tothradoslav @achtan, can we please reopen this issue? The navigation between the tabs is a real productivity killer.

sagrawal31 commented 2 months ago

Thank you, @tothradoslav for quickly reopening the issue.

Any thoughts on this-

Pressing ⌘LEFT or ⌘RIGHT does not work when the input field is focused either in Document, Aggregation or NodeShell tabs