search

mingo-app / mingo

Found a bug? have a FR ?
60 stars 2 forks source link

Mingo .deb package doesn't include logos #528

Open VladimirMikulic opened 1 year ago

VladimirMikulic commented 1 year ago

Describe the bug

When installing Mingo with native .deb format on Linux, .desktop file has invalid Icon path field. .desktop file on Linux is used for start menus so this results in blank icon for Mingo.

Screenshot_20230118_010941

Icon=mingo is valid, but you need to make sure the actual icons get installed in these folders:

Currently, there's only 1024x1024px logo in /usr/share/icons/hicolor/0x0/apps/mingo.png.

Screenshots

Screenshot_20230118_011255

Desktop (please complete the following information):

tothradoslav commented 1 year ago

Thank you for this. I added some configs to include the logo for the deb package specifically. However, I'll be honest with you, I'm not a linux user so it's hard to debug. Anyway, I will include this in the next RC. I will ask you to check it once it's released.

VladimirMikulic commented 1 year ago

Thank you so much @tothradoslav. Please feel free to tag me once it's ready, I'll be happy to test it and report back.

VladimirMikulic commented 1 year ago

Hi @tothradoslav! Reporting back on v1.11-rc2. Mingo still ships only one image: /usr/share/icons/hicolor/0x0/apps/mingo.png

Not sure if this fix was supposed to land in this RC, but just wanted to let you know.

VladimirMikulic commented 1 year ago

@tothradoslav Reporting back on v1.12.0 - the issue is still present.