mingo-app / mingo

Found a bug? have a FR ?
59 stars 3 forks source link

"Edit value" on an object incorrectly converts dates to strings #608

Closed bverhoeven closed 9 months ago

bverhoeven commented 9 months ago

Describe the bug

Inline editing an object (through "Edit value") converts date fields within that object to strings.

Screenshots

Note that, initially, the fields are dates/timestamps:

image

When right clicking on the field and using "Edit value" option, a textbox appears containing a JSON representation of the field:

image

Once saved, the fields that were once dates/timestamps are now strings.

image

Desktop (please complete the following information):

tothradoslav commented 9 months ago

Thank you, we have improved it, now it shows new Date() instead of simple string and when submitted, it's evaluated properly.

One minor comment: ideally, you should not be editing the object "lease" but the actual sub-values directly, such as the expiresAt. Just dbl-click the "expiresAt" and edit this directly, it will know it's a date, not an object.

tothradoslav commented 9 months ago

We have just released a release candidate with this issue corrected. Please check it out here: https://github.com/mingo-app/mingo/releases/tag/v.1.13.4

bverhoeven commented 9 months ago

Thanks for that elegant solution! I did some preliminary testing with 1.13.4-rc1 and from what I can see everything now works as expected.