mingrammer / diagrams

:art: Diagram as Code for prototyping cloud system architectures
https://diagrams.mingrammer.com
MIT License
38.92k stars 2.51k forks source link

Undefined names: Missing imports #356

Open cclauss opened 4 years ago

cclauss commented 4 years ago

DIscovered by #141 and related to #305... flake8 testing of https://github.com/mingrammer/diagrams

% flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./diagrams/oci/database.py:85:7: F821 undefined name 'AutonomousDatabase'
ADB = AutonomousDatabase
      ^
./diagrams/oci/database.py:86:12: F821 undefined name 'AutonomousDatabaseWhite'
ADBWhite = AutonomousDatabaseWhite
           ^
./diagrams/oci/database.py:87:13: F821 undefined name 'Databaseservice'
DBService = Databaseservice
            ^
./diagrams/oci/database.py:88:18: F821 undefined name 'DatabaseserviceWhite'
DBServiceWhite = DatabaseserviceWhite
                 ^
4     F821 undefined name 'AutonomousDatabase'
4

https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead, these tests are focus on runtime safety and correctness:

mingrammer commented 4 years ago

I'll check it. Thank you for reporting it.

Wildcarde commented 3 years ago

a few seem to have been removed since last time I used the oci entries:

I don't strictly need either of these, i was just using the 'emaildelivery' from oci.edge as a generic email (would be nice to just have postfix or even just 'email' in the onprem section if possible?). And the 'filestorage' to just indicate on prem nfs (would similarly be super helpful to have onprem.storage for the nfs)