search

mingyuanc / pe

0 stars 0 forks source link

Diagram is rather small #19

Open mingyuanc opened 10 months ago

mingyuanc commented 10 months ago

image.png

Same here, maybe replace with black boxes?

nus-pe-script commented 10 months ago

Team's Response

Thank you for the feedback! We have considered this issue before - If we abstract things into black boxes, we are afraid that this might make things worse for the readers because the diagrams will be scattered and they would not be able to see the diagrams in totality.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hey, thanks you the reply! My team and I actually ran into this issue as well and on way you could counter act this is by using reference frames

image.png

You could include the referenced frame directly below the main diagram, this would ensure that the diagram would not be scattered as well. This was what me and my team did as a small diagram would actually hinder the reader.

In your case, you could consider abstracting out the parsing part.