[Assignment 2] - Review my app

[minhchau273]

Hi @chug2k,

My app is completed. Please review :) Thanks.

[chug2k]

+1: nice work. I always expect the best from you. :shipit:

The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. You did an excellent job, as always.

Some tiny bugs/suggestions:

• I got an extra spinner here somehow.
• imageView.contentMode = UIViewContentMode.ScaleAspectFill for the business detail, perhaps?
• Get Direction is nice, but would it really be useful? Is there some way you can pop up a list of directions?
• Why is the address on the bottom? I didn't see it at first.
• You can make the phone number auto-clickable if you use a Data Detector. Try http://nshipster.com/nsdatadetector/, or you can use a UITextView instead and use yourTextView.dataDetectorTypes = UIDataDetectorTypePhoneNumber. Then clicking the number will open the phone application.
• Great job archiving the switch states!

• The if statement here is unnecessary:

    if delegate != nil {
      delegate?.selectCell?(self, didSelect: iconView.image!)
   }

• Likewise, instead of:

  let indexPath = tableView.indexPathForCell(dropDownCell)       
   if indexPath != nil {
   }

  You can just do

  if let indexPath = tableView.indexPathForCell(dropDownCell) {
  ...
  }

• Very creative with the idea of using Tap Gesture Recognizers. However, I think it would be better to use didSelectRowAtIndexPath because you get a row selection highlight effect. But either way, I would recommend you use the reloadSections withRowAnimation function - that way you can get a nice animation of the rows coming in, instead of the hard open/close.
• Excellent work with the map (sorry I couldn't help you too much :sob: ). Why did you use Google instead of Apple Maps? Usually it is easier to integrate MapKit.

Great work. :rocket:

[chug2k]

Ah, one more thing - instead of setting the frame on searchbar, you could have done something like:

navigationItem.titleView = UISearchBar()

[minhchau273]

Hi Sang,

• About the loading image at the 1st row, I couldn't find anything wrong with it :sweat:. Could you help me, please?
• "Is there some way you can pop up a list of directions?" - I don't really understand what you mean. I think getting direction from the current location to the business is necessary.
• At first, I used

navigationItem.titleView = UISearchBar()

but I cannot expand the search bar (or maybe I made something wrong :confused:). So I used setting frame.

Thanks a lot, Sang :blush:.

[chug2k]

• Loading image appears when I rotate the screen.
• I mean right now, you draw the directions on the map, but I would like a list of directions like
  • Turn left on A St.
  • Continue on A St for 2.3 km.
  • Turn right on B St.
• Ah, you are correct. ^^ Expanding is a little bit difficult. Good job.