[intro to iOS] [pre-assignment] - Review my app

[minhchau273]

hi, my app is completed, please review /cc @chug2k

[chug2k]

Wow! Very nice work. I am very impressed.

There are some small fixes you could make:

• In the U.S., it's customary to always show two decimal places: $2.50, not $2.5.
• This also means you should never show more than two decimal places. For example, your app shows I should pay a $1.665 tip when I try to select 15% of $11.10. The app should show $1.67 in that case (round up).
• You could better prevent against improper input. Currently, I am able to input $11.1.1.

I encourage you to also try some of the optional stories. But very good work. Your app looks great! You clearly have an eye for design.

[minhchau273]

Thanks for your encouragement!

I am preparing for the capstone project defense in 3 weeks so I don’t have too much time to spend for this app. But I will try to fix those bugs by August 11th.

About the optional tasks, I tried to make the keyboard be always visible. However, when I set becomeFirstResponder for the UITextField, the layout was not displayed properly.

[minhchau273]

Hi /cc @chug2k, I've fixed what you suggested and add some optional tasks (except the UI animation, as I'm using popover for the Settings). Check it out. Thanks :)

[chug2k]

Looks really good. Excellent submission. :+1:

[coderschoolreview]

Thanks for your Swift submission, minhchau273! :thumbs_up: Everything looks good with the format of your submission. We'll be providing a detailed review soon!

[coderschoolreview]

Thanks for your Swift submission, minhchau273! :+1: Everything looks good with the format of your submission. We'll be providing a detailed review soon!

[coderschoolreview]

Thank you for your Swift submission, minhchau273! Unfortunately there are some problems with your basic submission:\n

• I couldn't find how much time you spent on the assignment. Please include the number of hours spent on your assignment in your README.md.
• I couldn't find a walkthrough GIF referenced from your README.md. Please use RecordIt or LICEcap to record an animated GIF of your app in action, and include it in your README.md.
• I couldn't find a Heroku deploy link listed in your README.md. Please note the URL where you have deployed your app.

[coderschoolreview]

Thank you for your Swift submission, minhchau273!

Unfortunately there are some problems with your basic submission:

• I couldn't find how much time you spent on the assignment. Please include the number of hours spent on your assignment in your README.md.
• I couldn't find a walkthrough GIF referenced from your README.md. Please use RecordIt or LICEcap to record an animated GIF of your app in action, and include it in your README.md.
• I couldn't find a Heroku deploy link listed in your README.md. Please note the URL where you have deployed your app.

[coderschoolreview]

Thank you for your Swift submission, minhchau273!

fearful Unfortunately there are some problems with your submission:

• I couldn't find how much time you spent on the assignment. Please include the number of hours spent on your assignment in your README.md.
• I couldn't find a walkthrough GIF referenced from your README.md. Please use RecordIt or LICEcap to record an animated GIF of your app in action, and include it in your README.md.
• I couldn't find a Heroku deploy link listed in your README.md. Please note the URL where you have deployed your app.

[coderschoolreview]

Thank you for your Swift submission, minhchau273!

:no_entry: Unfortunately there are some problems with your submission:

• I couldn't find how much time you spent on the assignment. Please include the number of hours spent on your assignment in your README.md.
• I couldn't find a walkthrough GIF referenced from your README.md. Please use RecordIt or LICEcap to record an animated GIF of your app in action, and include it in your README.md.
• I couldn't find a Heroku deploy link listed in your README.md. Please note the URL where you have deployed your app.