'Compact empty folders' to work with 'Show files unreviewed'

minhdam / BitbucketDiffTree

Chrome extension to display diff tree for Bitbucket

MIT License

44 stars 10 forks source link

'Compact empty folders' to work with 'Show files unreviewed' #16

Open kopach opened 5 years ago

kopach commented 5 years ago

Currently, when both "Show files unreviewed" and "Compact empty folders" options enabled - there could be a case, when it's possible to still have folders compacted. Please, check screenshot below screenshot at feb 21 09-10-06

minhdam commented 5 years ago

Sorry @kopach but I'm not quite sure about this ticket. Could you please explain a little bit what is the current issue and what is your expectation? Thanks.

kopach commented 5 years ago

So, let me explain :). There are files under common/ folder which are not visible because are marked as reviewed. So, for this particular case (from screenshot) if I have option Compact empty folders enabled - I would expect to have following structure:

- src/
-- app/
--- common/services/rest/ <- note, common/ is concatenated to services/rest/
--- components/

Does it make sense for you?

minhdam commented 5 years ago

It makes sense. Thanks for your clarification. Will try to fix it soon.