hoanle
commented
8 years ago @vuminhkhang1995
Week 1: Instagram Viewer
:+1: thank you for your submission. The goal of this homework was to teach you RelativeLayout, ListView, networking with APIs, and loading remote images. These concepts are the foundation of nearly every app.
The app is great
A few notes after checking out the code:
- Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
- You should consider better organizing your source files
- Good to see you playing around with different layouts, views. Especially RelativeLayout, very popular and powerful
- You could consider overriding onFailure to handle network failures appropriately.
- Good job using the RecyclerView
- Nice to see you used the SwipeRefreshLayout for easy stream refreshes
- Good to see that you were able to successfully read the json object to display comments for photos.
- You used Butterknife but not in the proper way to reduce the extra code
You can read a detailed Project 1 Feedback Guide here which covers the most common points we see for this project, if you'd like to evaluate yourself further.
My app is complete. Please review :smile:
/cc @coderschoolreview @hoanle I integrated Recycler View as Brother Hoan suggested :+1: Thank you, anh :) Also, I still want to integrate more functionalities :((( Hope I have time to do it!!!!
Thank you CodeSchool