search

minht11 / local-music-pwa

Lightweight on device music player PWA.
https://snaeplayer.com/
MIT License
154 stars 20 forks source link

Would like to contribute more themes in CSS #32

Open mystery-z opened 10 months ago

mystery-z commented 10 months ago

I've been using this for a bit over a month and its great.

I'm kinda disappointed that there's only a dark/light theme though.

I'm happy to write some custom CSS stylesheets and contribute.

Would you be happy to accept some of these?

If so, where can I see the existing CSS code?

minht11 commented 10 months ago

How do you imagine these additional themes? Changing just colors or spacing sizes, even more? Completely custom styles are out of the question, styles and ui functionality are tightly coupled so it wouldn't be easy to maintain them.

Right now there is also support for dynamic theming based on artwork color, I likely wouldn't allow changing every single color by the user, because that is bad user experience and more choice isn't isn't always a good thing. Allowing to select few primary colors and shades of darkness, maybe.

Regarding stylesheets, there isn't one central stylesheet, each component defines their own styles, you can see the source code 😁

Overral custom themes are unlikely, variantions of the default theme, lets see, I am interested in your ideas though.