minhtran83 / crunchy

Automatically exported from code.google.com/p/crunchy
0 stars 0 forks source link

Relative "external links" are broken #135

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Steps to reproduce the problem?
1. Make a html page with a link like <a href="/relative/to/the/root.html"
title="external_link">link relative to the root of the server</a> or <a
href="relative/to/the/current_page.html" title="external_link">link
relative to the current page</a>
2. Open this page in Crunchy
3. Try to open a link

Instead to open the right page, this open a page where links are relative
to the crunchy server / page.
For the moment, Crunchy doesn't change urls in an "external_link". Instead
Crunchy should change relative links in absolute links.

Original issue reported on code.google.com by florian....@gmail.com on 25 Jun 2008 at 3:50

GoogleCodeExporter commented 9 years ago
I've fixed it in the florianbiree branch (r790). I have to update the test file.

Original comment by florian....@gmail.com on 25 Jun 2008 at 4:09

GoogleCodeExporter commented 9 years ago
Good catch!   I did not consider the case where external_link would not be 
referring
to a link on a remote site - but I can think of some use for this.

Original comment by andre.ro...@gmail.com on 25 Jun 2008 at 8:04

GoogleCodeExporter commented 9 years ago
There is an example in the croquant theme: I've changed the "edit" link to be an
"external link": when someone want to edit a page, it's edited without crunchy.

Original comment by florian....@gmail.com on 26 Jun 2008 at 10:44

GoogleCodeExporter commented 9 years ago
I've committed in my branch the tests for this fix.

Original comment by florian....@gmail.com on 26 Jun 2008 at 2:01

GoogleCodeExporter commented 9 years ago

Original comment by florian....@gmail.com on 26 Jun 2008 at 2:01

GoogleCodeExporter commented 9 years ago
included in the trunk.  Issue considered fixed.

Original comment by andre.ro...@gmail.com on 27 Jun 2008 at 9:51