minhtranite / react-notifications

Notification component for ReactJS

https://www.npmjs.com/package/react-notifications

287 stars 65 forks source link

#50 Rename deprecated lifecycle methods to UNSAFE #51

Closed user12043 closed 4 years ago

user12043 commented 5 years ago

As of react 16.3, componentWillMount, componentWillUpdate and componentWillReceiveProps lifecycle methods needs to be renamed to supress the warning about deprecation.

warning

more info here: https://hackernoon.com/problematic-react-lifecycle-methods-are-going-away-in-react-17-4216acc7d58b

50

tjrexer commented 4 years ago

I see that you've pushed a PR that re-names to UNSAFE. I've published a new fix under my fork, and am working with npm to take ownership for the packages to provide continued support. IF you still need the code, please review the new branch & repo here

New Repo: https://github.com/tjrexer/react-notifications

user12043 commented 4 years ago

good to hear that. I wonder if you going to upgrade the react version?

tjrexer commented 4 years ago

Eventually, working on one problem at a time. Going to have to go through issues on here and bring them over before I figure out all the updates I need to make.

tjrexer commented 4 years ago

@user12043 I've pushed a beta to npm that uses react 16 as version 1.6.0 (coincidence, not planned). If you want to use that and test it for me that would be great.