mini-software / MiniExcel

Fast, Low-Memory, Easy Excel .NET helper to import/export/template spreadsheet (support Linux, Mac)
https://www.nuget.org/packages/MiniExcel/
Apache License 2.0
2.81k stars 342 forks source link

Async implementation of freezing top row #684

Closed BaatenHannes closed 2 weeks ago

BaatenHannes commented 4 weeks ago

See issue #678. Added async implementation of PR #620 Freeze top row.

meld-cp commented 3 weeks ago

Hi @BaatenHannes, thanks for the PR. :)

I think to prevent repeating the Freeze pane code for the Async versions we can do the following:

This will ensure that the sync and async writers are using the same code to build the panes.

BaatenHannes commented 3 weeks ago

Hi @meld-cp, good point, didn't notice the DefaultOpenXml class. I refactored it to prevent the code duplication.

shps951023 commented 2 weeks ago

@BaatenHannes 👍👍👍 Merged, could we invite you to our team?