xmlseclibs.php should be defined as a thirdpartylib

miniOrange-git / moodle-auth_mo_saml

miniOrange SAML moodle plugin

GNU General Public License v3.0

0 stars 0 forks source link

xmlseclibs.php should be defined as a thirdpartylib #2

Open danmarsden opened 6 years ago

danmarsden commented 6 years ago

you should remove the moodle gpl header and moodle specific changes and add a thirdpartylib.xml file with the details: https://docs.moodle.org/dev/Plugin_files#thirdpartylibs.xml

(this also excludes the file from some of the Moodle coding guideline checks.)

danmarsden commented 6 years ago

this also appears to be a 4yr old version of the lib with a number of custom changes by you - it would be better to upgrade to the latest version of xmlseclibs.php and provide proper documentation of the changes you make to the lib so it is easy to see that all security updates have been applied to the lib.