Remove exjsx dependency

minibikini / paasaa

🔤 Natural language detection for Elixir

MIT License

114 stars 12 forks source link

Remove exjsx dependency #12

Closed Zinggi closed 5 years ago

Zinggi commented 5 years ago

Hi Egor

Thank you for your library. We want to use it in a current project, but don't want to include yet another json library. Since it wasn't really needed here, I removed it in this PR.

By the way, maybe you want to expose Paasaa.detect_script/1, because currently mix bench is broken since it's private.

coveralls commented 5 years ago

Coverage decreased (-4.0%) to 86.957% when pulling 445ac0f0956b2bd9d735106e9d90886c327234f5 on simplificator:master into babf1eb8f60e1804b91765788b2f79d9430a7bd5 on minibikini:master.

minibikini commented 5 years ago

Released in v0.4.0!

Thanks a lot, @Zinggi! Sorry it took me long to review (was busy at work).

Zinggi commented 5 years ago

@minibikini Great, thanks for your work!