Closed KraXen72 closed 5 months ago
I have converted to draft to implement requested changes
@minibits-cash please review when you got the time. thanks!
Code did not make manually entered / pasted lightning:ADDRESS pass as onComplete code did not strip the prefixes. Made changes:
Needs some testing.
Prettified Mint info screen, auto-paste token or lightning invoice, address or code.
This PR revamps the Mint Info screen
ProfileHeader
intoAvatarHeader
(ProfileHeader
is now a thin wrapper aroundAvatarHeader
), so it can be used inMintInfoScreen
/components
MintInfoScreen
as wellCollapsibleText
component)@fortawesome/free-brands-svg-icons
for Brand icons (twitter, reddit, etc). Pleaseyarn install
and build the app when testing.BottomModal
as i felt it's not really representative of how other apps/Material Design does ityarn adb:inspect
andyarn adb:unreverse
. Inspect opens the inspector on the connected device (can also be done by shaking it) and unreverse removes the reversed ports without having to disconnect the device (sometimes needed).On device information
part - let me know if/what would you like me to do with it. Thanks!Screenshots on telegram, upon request I will add them here as well.
I have tested the changes in app and i am quite happy with the result, but please do let me know if there's anything you want to change/improve further.
Please test the changes and review the pull request's code changes. Thanks!
closes #67
PR part 2: implemented validation & auto-paste for TokenReceiveScreen and PayWithLightningScreen closes #78