Lightning: Support for payment comments, Tor mint support

KraXen72 commented 1 month ago

closes #48, closes #75

lightning: payment comment support

EDIT: this is out of date. comment is now edited during amount editing stage. invoice is only encoded once. The comment has to be encoded in the invoice for it to be sent.
Since the whole system is somewhat complicated, and i couldn't make sense of it, i made this small diagram.
Stuff in green is what i changed.

We have two options

re-encode the invoice whenever the user hits done on the comment input field:
extra loading time whenever you hit done. kind of bad UX.
no need to encode the invoice when hitting the Pay now button
only encode the comment when user hits Pay now
no extra loading time when changing the comment, can do many edits to it quickly
extra loadig time when hitting Pay now
```
## Tor mint support
```
[x] added better error message when Tor VPN is not running

KraXen72 commented 1 month ago

thanks for the pointing comments, i'll follow them. since this pr is marked as a draft, it's not done yet.

KraXen72 commented 3 weeks ago

@minibits-cash i've tested it and it worked, however, there are currently a few issues with it:

whenever i hit the done button on the memo input field, i call onAmountInputEndEditing to re-calculate the encoded invoice url, with the new comment url parameter. this creates a bit of (unnecessary?) lag/waiting time for the user. can we do something about this?
- ~~maybe the invoice url could just be re-calculated once, with the comment, when hitting pay, instead of whenever the comment is edited (not entirely sure how i'd do this though)~~ -> done
~~whenever i hit done on the comment editing, whatever mint was selected as the one to pay from gets reset to the first one in the list. I've tried fixing this but to no avail.~~ -> fixed
You can't "submit" or save the comment without hitting done (the input field will still be focused even when you hide the keyboard or tap elsewhere) not that big of an issue

~~I was also thinking about maybe moving the comment input to the first stage, when the amount is inputted, but i'm not sure about it.~~ -> not viable, amount input has all the focus and when user hits enter it takes them to the other screen. please let me know your opinion these problems. Thanks!

KraXen72 commented 3 weeks ago

you might want to load the large diffs as well - i avoided re-formatting as best i could, but maybe prettier's format selection command had a few side-effects and formatted more than i was currently working with...

KraXen72 commented 3 weeks ago

As a part of this pull request i will also include some small changes to the MintInfoScreen to fix bugs reported by a user on Telegram - namely showing support checkmark for nut15 - multi-path payments

KraXen72 commented 3 weeks ago

@minibits-cash i have updated the PR description and https://github.com/minibits-cash/minibits_wallet/pull/83#issuecomment-2184131272 comment, please see the changes i've made. I've tested it by sending sats to Wallet of Satoshi and it works.

EDIT: comment is not being sent to WoS, looking into it

KraXen72 commented 3 weeks ago

there is one more bug that sometimes happens: 'Not ready... exiting', when i enter the comment and hit confirm. it causees the comment and amount to reset, and when you input it again, it works. it doesen't happen all the time, so i can't reliably reproduce it yet to fix it.

it really mostly doesen't happen.

KraXen72 commented 3 weeks ago

please do not merge yet, i'm planning to add the Tor guide.

minibits-cash commented 3 weeks ago

there is one more bug that sometimes happens: 'Not ready... exiting', when i enter the comment and hit confirm. it causees the comment and amount to reset, and when you input it again, it works. it doesen't happen all the time, so i can't reliably reproduce it yet to fix it.

it really mostly doesen't happen.

Could not simulate so far.

minibits-cash commented 3 weeks ago

Recent changes - Fixed that lnurl comment did not make it to transaction detail of the payer. Quick fix that payment preimage was not logged into the audit trail. Made comment visible but consuming less space after invoice is generated.

Tested that comment is correctly passed to Wallet of Satoshi and Minibits wallet of the payee.

Still todo: test non-lnurl transfer types to avoid regressions.

KraXen72 commented 3 weeks ago

nice improvements! thanks!

KraXen72 commented 3 weeks ago

i tested an ecash payment from minibits to minibits (official mint) with and without a memo and both worked well without any issues.

minibits-cash commented 3 weeks ago

i tested an ecash payment from minibits to minibits (official mint) with and without a memo and both worked well without any issues.

I meant to test non-lnurl based transfers, donations, payment requests processed in TransferScreen, not ecash sends that we did not touch.

KraXen72 commented 3 weeks ago

I meant to test non-lnurl based transfers, donations, payment requests processed in TransferScreen, not ecash sends that we did not touch.

@minibits-cash how can i test these? thanks.

minibits-cash commented 3 weeks ago

I meant to test non-lnurl based transfers, donations, payment requests processed in TransferScreen, not ecash sends that we did not touch.

@minibits-cash how can i test these? thanks.

Basic flow:

Create invoice via Receive/Topup or in any Lightning or ecash wallet
Pay it from Minibits by scanning / pasting the invoice

Payment request (in Minibits this is lightning invoice shared with a contact over Nostr relay)

Receive payment request from anothe Minibits wallet
Pay it from Minibits

Donation:

Book custom wallet address
Pay generated invoice from the same Minibits wallet

minibits-cash / minibits_wallet

Lightning: Support for payment comments, Tor mint support #83

lightning: payment comment support