search

minichate / ember-cli-conditional-compile

Conditional Compilation (Feature Flags) for Ember
MIT License
33 stars 17 forks source link

Release or backport ember-cli-babel change? #109

Open jherdman opened 2 years ago

jherdman commented 2 years ago

The current version of this project specifies a tightly constrained version of ember-cli-babel:

https://github.com/minichate/ember-cli-conditional-compile/blob/eb8cb5d8de1ef936f596c223f79febaa85ae7d44/package.json#L54

This results in the following warning when building an application:

WARNING: [DEPRECATION] [DEPRECATION] Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead.

See https://deprecations.emberjs.com/v3.x/#toc_ember-global for details.

Usages of the Ember Global may be caused by an outdated ember-cli-babel dependency. The following steps may help:

SNIP SNIP SNIP

* ember-cli-babel@7.4.3, currently used by:
  * ember-cli-conditional-compile@1.2.0 (Dormant)
    * Depends on ember-cli-babel@~7.4.0

As this project is marked DORMANT above it doesn't really add to the noted problem, but it does add to the background noise of day-to-day work.

Would it be possible to do a release (or backport) the changes required to loosen the version constraint of ember-cli-babel?

jherdman commented 2 years ago

Apologies for nagging, but I'd like to draw a little attention to this.

halfbyte commented 2 years ago

@jherdman I think we're relatively close to releasing a new version. How would the ideal constraint from your vantage point look like? On HEAD we're currently using ^7.26.11 which is much more relaxed but is more constrained downwards, I guess.

jherdman commented 2 years ago

That constraint works well for me. I'm looking forward to the new release!

halfbyte commented 1 year ago

@jherdman Could you please test if 2.0.0 fixes your issue? Sorry for this taking so long!

jherdman commented 1 year ago

Apologies. I've since moved on from the project in question. Feel free to mark this as closed.