search

minichate / jscs-ember-deprecations

Ember deprecation warnings for JSCS
MIT License
6 stars 1 forks source link

Adding `disallowInjectedContainerAccess` to warn about Ember 2.3 deprecations. #33

Closed workmanw closed 8 years ago

workmanw commented 8 years ago

Also resolves #4.

This is my first time ever working with JSCS or ESTrees so it's very possible there is a better way to handle this. Willing to take any feedback.

Also, it seems counter intuitive to start with the Ember 2.3 deprecation (instead of the outstanding Ember 2.2), but that one seems very hard, possibly impossible. I will comment further on that story.

minichate commented 8 years ago

This looks great!

minichate commented 8 years ago

I'm happy merging this as-is if you'd like; or if you feel like fixing https://github.com/minichate/jscs-ember-deprecations/pull/33#discussion_r50935987 I can wait

workmanw commented 8 years ago

It'd be great to change these messages to requires a boolean value to match conventions.

Yeap, Agreed. Change made.

Thank you for this repo! It's be a huge help for us :)

minichate commented 8 years ago

Shipped in 0.0.27