search

minicloudlabs / helm-charts

minicloud helm charts
MIT License
24 stars 16 forks source link

allow configuring extra containers as sidecar #64

Closed bakito closed 1 year ago

bakito commented 1 year ago

Hi

It would be nice if I had the possibility to define additional containers to the deployment. Eg: a web interface to access the SQLite db directly. This would helm me, as gatus by default limits the number of records returned by the database and I can not access older results, although they are kept for 7 days in the DB

avakarev commented 1 year ago

@bakito Thank you for the PR, I appreciate your work. And thank you for the subject clarification.

In general, I'm not sure if it's a best idea to open same sqlite file from two containers. It supports multi-process reads, but requires locking for writes. It could be a better option to switch to PostgreSQL backend and deploy your alternative gatus-ui app as separate chart / deployment.

Anyway, I see your request for sidecar containers and totally fine to add them. Unfortunately this PR is not ready to merge cause initContainers is not what you want to add. I it also make sense to respect "main" securityContext. Sidecar containers are shipped with gatus-chart 3.2.0.

Please let me know if you are able to add containers now and it do the job.

bakito commented 1 year ago

@avakarev it works fine. Thank you very much