minicloudlabs / helm-charts

minicloud helm charts
MIT License
24 stars 16 forks source link

Gatus: Add ability to use existing Secret in extraVolumeMounts list #90

Closed PurseChicken closed 10 months ago

PurseChicken commented 10 months ago

This PR adds the ability to use an existing secret in the extraVolumeMounts list. An example of how to do this is in the values file, however its basically the same as using a configMap.

E.G.

  - name: extra-volume-3
    mountPath: /mnt/volume3
    readOnly: true
    existingSecret: secret-name

When specified, the volume for that list item will use secret.secretName.

PurseChicken commented 10 months ago

@avakarev Can we get this reviewed and merged up?

I am also happy to bump the chart.yaml version and the gatus appVersion as well (since there are newer builds).

avakarev commented 10 months ago

@PurseChicken heya. Sorry for the delay, I'll check your PR and also make some extra changes on weekend.

avakarev commented 10 months ago

@PurseChicken thank you for your contribution