Adjust vertical alignment of hamburger icon

minicomp / ed

A Jekyll theme for minimal editions :book:

https://minicomp.github.io/ed/

Other

247 stars 129 forks source link

Adjust vertical alignment of hamburger icon #28

Closed bobbylcraig closed 2 years ago

bobbylcraig commented 3 years ago

Sorry to intrude on your theme, but I made this change for my local blog and thought y'all might want to consider it for the main source. Basically, it's just adding vertical alignment to the hamburger icon when the menu is expanded. Right now it looks slightly high.

Before:

After:

Just a 1 line diff. Let me know what your thoughts are. Happy New Year.

elotroalex commented 2 years ago

Sorry, the maintenance of the site went to someone else for a while, but I just got it back. I noticed this pull request is not passing tests. If you're still amenable, would you mind checking to see why and pushing it again? I like your fix.

bobbylcraig commented 2 years ago

Hey @elotroalex, holy necro-contribution. I rebased. Lmk if there're further issues.

elotroalex commented 2 years ago

Love it! Thank you @bobbylcraig. Merging the pr. Now

elotroalex commented 2 years ago

ha! closed it before merging.