search

minicomp / wax

Jekyll based framework for minimal exhibitions with IIIF 🐝
https://minicomp.github.io/wax/
MIT License
158 stars 84 forks source link

Map2 #174

Closed awoods closed 10 months ago

awoods commented 11 months ago

Supersedes: https://github.com/minicomp/wax/pull/149

This feature adds a new option/page in the navbar that displays all items in the collection that have a value in the latitude and longitude columns in the project CSV file. This works out-of-the-box.

This is a port from https://github.com/CollectionBuilder/collectionbuilder-csv.

Related user documentation pull-request: https://github.com/minicomp/wiki/pull/34

For an existing demonstration: https://history.lakecountypubliclibrary.org/cmhc/map/

awoods commented 11 months ago

The HTML Proofer error will go away once this PR is merged. It is looking for a published page (https://minicomp.github.io/wax/map/) that is being created in this PR.

mnyrop commented 11 months ago

@awoods thanks for this! we'll need to stash the PR for awhile since we need to think more holistically about how to expand theme features for a v2 (i.e., what layouts/includes should be in a core theme? what components could live as "extensions" and how might that work? what could exist as a curated "recipe" for others to implement?) maps are probably the top feature for us to really think about in this regard. so with that said, i'll probably close the PR and reach out if/when we reopen or integrate it into a new version.

in the meantime, is there a preferred way for me to boost this work you've done as a model? is there a blog post/write up/documentation that exists? if not i can try to think of a way to highlight the repo & live site on our (WiP) examples list and tag it for mapping. it looks really great and should definitely get boosted to the community.