search

miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.49k stars 704 forks source link

Upgrade to the new Shiori API once released #2074

Open fierceX opened 10 months ago

fierceX commented 10 months ago

Update the api of shiori. The current api has been abandoned and doesn't work on the latest version of shiori. You want to update the api of shiori.

https://github.com/go-shiori/shiori/blob/master/docs/APIv1.md

fguillot commented 10 months ago

The Miniflux integration is tested against the latest stable version of Shiori which is currently v1.5.5 at the time of writing this comment.

The new Shiori API could be implemented in Miniflux after the Shiori authors release a new stable version.

cendenta commented 3 months ago

APIv1 is mentioned in the release notes of Shiori v1.6.0. However, it doesn't seem stable quite yet (it mentions running legacy and new APIs at the same time). Hopefully it will stabilize soon, as the Miniflux integration doesn't seem to work for this version.

mateusjdev commented 3 months ago

Old api is still working (for now) with a new endpoint, is a easy patch: https://github.com/mateusjdev/miniflux/commit/53f2c4f3111fb267d610174cf7bcb745a6371a94 but it will fail with Shiori v1.5.5 or older

essys commented 3 months ago

The Miniflux integration is tested against the latest stable version of Shiori which is currently v1.5.5 at the time of writing this comment.

The new Shiori API could be implemented in Miniflux after the Shiori authors release a new stable version.

The new API was introduced to the current stable release which currently is v1.6.2. Is it possible to integrate adaptations to the new API structure to Miniflux?

mateusjdev commented 2 months ago

The new API was introduced to the current stable release which currently is v1.6.2. Is it possible to integrate adaptations to the new API structure to Miniflux?

It's possible but still not finished right now, on version v1.6.2 the new API endpoint doesn't support bookmark creation, in shiori roadmap it is planned to v1.9.0, then: