Fix: Clean filter rules of Carriage Returns

miniflux / v2

Minimalist and opinionated feed reader

https://miniflux.app

Apache License 2.0

6.99k stars 727 forks source link

Fix: Clean filter rules of Carriage Returns #2726

Closed privatmamtora closed 4 months ago

privatmamtora commented 4 months ago

Sanitize the filter rules to remove "\r" from text area value (shows up on windows)
Update the comment in the Rule Validator specifying the Rule format (FieldName=RegEx\nFieldName=RegEx...)

Do you follow the guidelines?

[X] I have tested my changes
[X] There is no breaking changes
[X] I really tested my changes and there is no regression
[X] Ideally, my commit messages use the same convention as the Go project: https://go.dev/doc/contribute#commit_messages
[X] I read this document: https://miniflux.app/faq.html#pull-request

@fguillot I just thought about this and was about to add it to #2677, but I saw it was already merged, So made another pull request

privatmamtora commented 4 months ago

@fguillot No it seems from my test that Windows text area values use \r\n, not \n. Results from my test: Windows textarea value contains \r\n. (Firefox) Mac textarea value contains \n. (Chrome)

When I debugged it on windows, because it is only splitting on \n, the regexp rule ends up containing a \r, which might cause the regexp to fail.

fguillot commented 4 months ago

While you are at it, it would be nice to document this new feature on the website: https://github.com/miniflux/website/tree/main

privatmamtora commented 4 months ago

@fguillot I added some documentation for the Global Rules: https://github.com/miniflux/website/pull/80