search

miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.65k stars 706 forks source link

MEDIA PROXY URI Composition Error #2769

Closed Qeynos closed 3 days ago

Qeynos commented 1 month ago

BASE_URL=https://example.com:88/Miniflux/ MEDIAPROXY* keep default

I have checked the image URL issued by Miniflux, which is https://example.com/Miniflux/proxy/..., and found that the non-standard port number is missing in the link.

Qeynos commented 1 month ago

I tried the last nightly build, and the image proxy URL is 'https://example.com:88/Miniflux/Miniflux/proxy/...'. When I open it in the browser, it shows '404 Page Not Found'. If I manually change it to 'https://example.com:88/Miniflux/proxy/...', the browser displays 'Unable to decode this URL'. @fguillot

The MEDIA_PROXY_MODE is set to 'all', and other proxy parameters remain at their default values.

Qeynos commented 1 month ago

If I manually change the URL to 'https://example.com:88/Miniflux/proxy/...' in the RSS reader's database, it can retrieve the image, so it seems like we just need to correct the incorrect URI.

Qeynos commented 1 month ago

https://github.com/miniflux/v2/blob/569529d73b4413401959cec8390e8c5c19d57053/internal/mediaproxy/url.go#L45

Both config.Opts.BaseURL() and proxifiedUrl contain URI "Miniflux", which might be the cause of the issue. @fguillot

Qeynos commented 3 weeks ago

fixed in the recent release, thanks.

fguillot commented 2 weeks ago

PR #2813 should fix the issue this time.

Qeynos commented 2 weeks ago

I may have made a mistake before, the issue with the URI was not completely resolved in version 2.2.0. Now I have compiled and tested the latest code, and I conducted some A/B comparison tests with version 2.2.0, the Reeder can correctly fetch images in the latest version of the code.