miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.97k stars 728 forks source link

Is "Mark items as read on click/middle click of external links" deprecated? #2789

Open Sevichecc opened 3 months ago

Sevichecc commented 3 months ago

In the latest version of Miniflux, when users click the external link button, the entry is no longer marked as read automatically as it was before. Is this change a result of a deliberate refactor or is it potentially a bug?

xfzv commented 3 months ago

Works as expected with https://github.com/miniflux/v2/commit/bcbf9f402512353c4d0eb6a8209c5ff04e8bc56a here (and I've run 2.1.4 at some point too but never had this issue) so I think it's probably a bug on your end.

SansGuidon commented 3 months ago

Maybe a side effect of the latest update of Miniflux that introduced the feat: mark media as read when playback reaches 90% and hence changed the list of preferences for when to mark an entry as read ?

I've noticed that my default preference were changed after the update of Miniflux, I was automatically opted out of "Automatically mark entries as read when viewed" and I was automatically opt in with "Mark entries as read manually".

If I'm not mistaken, it's a side effect of the update, but I wonder if it's the same for you @Sevichecc . What are your current Reader settings ?

Sevichecc commented 2 months ago

@SansGuidon I've tried all possible prefrence settings, but the problem persists. My Miniflux version is v2.2.0. I plan to install a fresh Miniflux instance on my newly set up VPS to see if it works as expected. The issue might be related to my current machine configuration.

ztec commented 2 months ago

@Sevichecc I was not aware of such feature. Are you sure it was an expected behavior previously ?

I quickly tested with an old version of miniflux and I have the following behavior:

@SansGuidon the feat: mark media as read when playback reaches 90% should not change anything regarding your previous options. At the same time of the previous tests I mentioned, I checked whether the options selected changed and the behavior was the one expected. Basically two options are expected (and happened in my tests):

The two other options cannot be selected by default. That not the intended behavior anyway. ~I need to do more thorough tests on that to be sure on my side~ I did, and the option checked always convert into Automatically mark entries as read when viewed in my test environment. (2.1.4 upgraded to 2.2.0 with the database migration between the two)

ps, I made the feat: mark media as read when playback reaches 90% change so I'm willing to investigate and fix anything I did wrong.

Sevichecc commented 1 month ago

@ztec @SansGuidon Recently, I transitioned from a Chromium-based browser to Firefox and discovered that the "Mark items as read on click/middle click of external links" feature works on Firefox (Developer Edition v.131.0b9) but not on Chromium-based browsers (tested on Brave v.1.70.117 and Chrome Canary v.131.0.6733.0).

When investigating using the browser's developer tools, specifically in the Network tab, I found that the POST request to https://${miniflux_instance}/entry/status is not triggered in Chromium-based browsers. This leads me to believe that the issue might be related to changes in browser behavior rather than Miniflux itself.

Could this difference in browser behavior possibly explain the inconsistency we're seeing? I'd appreciate your thoughts on this observation.