search

miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.97k stars 728 forks source link

Substack comments #2828

Open emilknievel opened 2 months ago

emilknievel commented 2 months ago

Unsure if this should be a feature request or a bug but here goes:

I have noticed that articles from Substack don't have a link to the comments. I really appreciate having that option when I'm reading hackernews links etc. and would love for the same to exist for the articles from substack.

Best regards, Emil

moppman commented 2 months ago

I'm not sure this is feasible.

For hackernews feed items[0], miniflux displays a comments link because it's part of the actual RSS feed.

From the RSS spec:

<comments> is an optional sub-element of <item>

and also here in miniflux' implementation: https://github.com/miniflux/v2/blob/8708a109b314c78a8adccf80e4fb58940c6ac4b3/internal/reader/rss/rss.go#L131

Unfortunately, Substack[1] does not provide the <comments> element for their feeds.

That means miniflux would need some custom logic that adds a https://substack_url.com/comments[2] link to each entry.

[0]: hackernews feed example: https://news.ycombinator.com/rss [1]: random Substack feed example: https://www.astralcodexten.com/feed [2] random Substack comments link example: https://www.astralcodexten.com/p/open-thread-345/comments

emilknievel commented 2 months ago

Ah, I see. Thank you for the clarification.