miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.97k stars 728 forks source link

fix: remove enclosure progression save data on shared entry #2831

Closed ztec closed 2 months ago

ztec commented 2 months ago

Shared entry does not link to any user and therefore should not display any saved progression. Curiously, the progression of a user (the one that shared ?) was still integrated in the page. This does not make sens regarding the sharing feature itself. It is also a leak of user personal information onto a public page.

I simply removed the data from the template when the user object is not present. I tested the change on "regular" entry page, ensuring the save progression feature still works, and on shared page checking if any error happened in the JavaScript console. Everything seems in order.

Do you follow the guidelines?