Cache feed icons - Githubissues

miniflux / v2

Minimalist and opinionated feed reader

https://miniflux.app

Apache License 2.0

6.97k stars 728 forks source link

Cache feed icons #2856

Closed APT37 closed 1 month ago

APT37 commented 2 months ago

[x] I have read this document: https://miniflux.app/opinionated.html#feature-request

Since feed icons are fetched only once (when the feed is added) and never refreshed afterwards, I think it'd be a good idea to let the local device cache them instead of loading them from the server every time.

Maybe a feature to update feed icons would be useful too - maybe even support for custom icons.

xfzv commented 2 months ago

Relevant PR (at least for the refreshing part): https://github.com/miniflux/v2/pull/2123

APT37 commented 2 months ago

I see. Good to know that's already being worked on. After reading the PR comments, it seems like a whole different can of worms on it's own.

Of course this doesn't have anything to do with caching, haha.

fguillot commented 1 month ago

Feed icons are already cached in the browser for at least 72 hours.

https://github.com/miniflux/v2/blob/562a7b79a57bc9f3b25225486084fcb9da84b7d2/internal/ui/feed_icon.go#L28-L36

You can see that in the browser console:

APT37 commented 1 month ago

I should've checked what's actually happening. At the time I opened the issue, icons were loading rather slowly and it looked like they had to be fetched from the server each time the page was loaded.

Closing this one, since it's only about caching the icons, which is already happening.