search

miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.97k stars 727 forks source link

Keyboard shortcuts and some links not working in Edge (PWA) #2911

Closed pro-sumer closed 2 weeks ago

pro-sumer commented 3 weeks ago

I want to run Miniflux as an Edge PWA app (I'm not allowed to install any software on this PC; Edge is the only browser installed), but keyboard shortcuts and some links (like marking all items read) don't work: nothing happens when I type that key or click on such link (not even the red confirmation question).

fguillot commented 3 weeks ago

I tested with Windows 11 23H2 / Microsoft Edge 130.0.2849.56 (Official build) (64-bit), and the keyboard shortcuts works fine for me.

I don't have access to any other Windows configuration. I don't know much about the business of version of Microsoft Edge, but I'm assuming IT administrators can disable some features for security reasons.

Does the keyboard shortcuts works without the PWA installed?

pro-sumer commented 3 weeks ago

Does the keyboard shortcuts works without the PWA installed?

I think they didn't, but don't have access to the machine with the problematic behavior today.

Shortcuts & links work fine on my MacBook Pro, both in Safari and as a PWA.

pro-sumer commented 3 weeks ago

Did try it on another PC (with the regular Edge) though and same issue: keys/links not working.

pro-sumer commented 3 weeks ago

Does the keyboard shortcuts works without the PWA installed?

No, they don't work then either.

Which other information do you need?

fguillot commented 3 weeks ago

Do you see any Javascript error in the browser console?

Just to be sure, the keyboard shortcuts option is the user settings is enabled?

pro-sumer commented 3 weeks ago

Yes, the keyboard shortcuts option is enabled.

There are indeed errors in the JavaScript console:

For settings:1782:

Refused to execute inline script because it violates the following Content Security Policy directive: "default-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-<REDACTED>'), or a nonce ('nonce-...') is required to enable inline execution. Note also that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.

and for rocket-loader.min.js:1:

This document requires 'TrustedScript' assignment.

and (also) for rocket-loader.min.js:1:

Uncaught TypeError: Failed to set the 'textContent' property on 'Node': This document requires 'TrustedScript' assignment.

I wonder why this is not a problem in Safari. Hope to check its console later today.

pro-sumer commented 3 weeks ago

Same/similar errors in Safari on macOS, but keyboard and shortcut links work.

(So not related?)

fguillot commented 2 weeks ago

You need to disable the Rocket Loader feature in your Cloudflare settings.

https://developers.cloudflare.com/speed/optimization/content/rocket-loader/

When this feature is enabled, Cloudflare injects its own Javascript in the page, and obviously it breaks everything.

pro-sumer commented 2 weeks ago

You need to disable the Rocket Loader feature in your Cloudflare settings.

That indeed fixed both keyboard shortcuts and links!

Thank you for pointing this out (I had done this for other self-hosted services, but forgot to check this for Miniflux).