search

miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.94k stars 726 forks source link

Differences in feed modification behavior between Web UI and API #2936

Open AiraNadih opened 4 days ago

AiraNadih commented 4 days ago

I noticed that when modifying a feed through the web form (e.g., disabling the feed), upon form submission, both the parsing error count and error message of that feed are reset. However, this reset process doesn't occur when modifying the feed via API.

After examining the relevant code, I found that the reset operation appears to be automatically performed during form processing:

https://github.com/miniflux/v2/blob/c3016a4c5554a46a703828ddb46d2047d4abccf6/internal/ui/form/feed.go#L58-L59

This operation is not present in the API modification flow.

I'd like to know if this difference in behavior is intentional or an oversight.

If it's not intentional, perhaps we could synchronize this logic by adding originalFeed.ResetErrorCounter() to the API handling code.

fguillot commented 2 days ago

It's probably an oversight. The same behavior could be added to the API endpoint for consistency.