search

miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.97k stars 728 forks source link

Icon downloaded from feed URL instead of site URL #2955

Open gabe565 opened 10 hours ago

gabe565 commented 10 hours ago

Hey!

I recently force refreshed some feeds and noticed that the feed icon is now downloaded based on the feed URL instead of the website URL. This was introduced by #2871 because the NewIconChecker now uses c.feed.FeedURL instead of c.feed.SiteURL: https://github.com/miniflux/v2/blob/c6c71c58b89cfff694e847dd50ff74bf2d15a27a/internal/reader/icon/checker.go#L37

This is fine in most cases, but for any feeds that use an RSS generation service like RSS-Bridge, RSSHub, or one I built called Transsmute, the feed generator's icon will be downloaded instead of the actual website icon.

I wouldn't mind opening a PR to fix this, but I wasn't sure if the change was intended.