2871 was a huge improvement to the handling of feed icons, but I've found a bug. When force refreshing, the icon defined in a feed's XML is ignored. This is because the icon URL is not persisted, resulting in originalFeed.IconURL always being an empty string. This PR fixes this by assigning the value from updatedFeed.IconURL before refreshing the icon.
Do you follow the guidelines?
[x] I have tested my changes
[x] There are no breaking changes
[x] I really tested my changes and there is no regression
2871 was a huge improvement to the handling of feed icons, but I've found a bug. When force refreshing, the icon defined in a feed's XML is ignored. This is because the icon URL is not persisted, resulting in
originalFeed.IconURLalways being an empty string. This PR fixes this by assigning the value fromupdatedFeed.IconURLbefore refreshing the icon.Do you follow the guidelines?