search

minijaham / ObsidianBreakerTNT

Make obsidians breakable with TNT
GNU General Public License v3.0
0 stars 2 forks source link

Fixed Crash | Check Pull Requests #2

Open XyloFD2 opened 6 months ago

XyloFD2 commented 6 months ago

[12:08:25.471] [Server thread/CRITICAL]: ErrorException: "Undefined property: minijaham\ObsidianBreakerTNT\ObsidianData::$block" (EXCEPTION) in "plugins/ObsidianBreakerTNT.phar/src/ObsidianData" at line 31

XyloFD2 commented 6 months ago

I fixed it, I made a pull request with both of the fixes for the main.php and the ObsidianData.php file.

XyloFD2 commented 6 months ago

Also theres a issue/suggestion image

XyloFD2 commented 6 months ago

The tnt will only break the Obsidian if it is to land onto a block right next to the obsidian if the obsdiain blocks that are on the side of the tall wall werent there and the tnt was to explode on the wall it wouldnt damage it.

minijaham commented 6 months ago

Reference in

Weird. It should be blowing every block that the TNT touches.

minijaham commented 6 months ago

[12:08:25.471] [Server thread/CRITICAL]: ErrorException: "Undefined property: minijaham\ObsidianBreakerTNT\ObsidianData::$block" (EXCEPTION) in "plugins/ObsidianBreakerTNT.phar/src/ObsidianData" at line 31

This error should be fixed in the latest commit. Sorry about that haha

XyloFD2 commented 6 months ago

Reference in

Weird. It should be blowing every block that the TNT touches.

Yea Its weird, Cause the tnt has to land a block for it to actually do dmg to the Obsdiain, Could you try fixing it, Cause I don't know what that issue is

XyloFD2 commented 6 months ago

Also, I got a question, Is there a way to make it break more than 1 block? after the tnt explodes?

XyloFD2 commented 6 months ago

like make the TNT blast radius bigger or something for the tnt breaking the obsidian

minijaham commented 6 months ago

Also, I got a question, Is there a way to make it break more than 1 block? after the tnt explodes?

Yeah. You just need to use a loop from the block that the TNT touches as well.

minijaham commented 6 months ago

Also, I got a question, Is there a way to make it break more than 1 block? after the tnt explodes?

Yeah. You just need to use a loop from the block that the TNT touches as well.

Or actually have a detection for the TNT explosion, but not sure how that can be implemented. I need to look.

XyloFD2 commented 6 months ago

Also, I got a question, Is there a way to make it break more than 1 block? after the tnt explodes?

Yeah. You just need to use a loop from the block that the TNT touches as well.

Or actually have a detection for the TNT explosion, but not sure how that can be implemented. I need to look.

If there is a way Could you possibly implement it into the plugin? as a config option?

minijaham commented 6 months ago

Also, I got a question, Is there a way to make it break more than 1 block? after the tnt explodes?

Yeah. You just need to use a loop from the block that the TNT touches as well.

Or actually have a detection for the TNT explosion, but not sure how that can be implemented. I need to look.

If there is a way Could you possibly implement it into the plugin? as a config option?

I can, but I can't test it atm 😭

XyloFD2 commented 6 months ago

Also, I got a question, Is there a way to make it break more than 1 block? after the tnt explodes?

Yeah. You just need to use a loop from the block that the TNT touches as well.

Or actually have a detection for the TNT explosion, but not sure how that can be implemented. I need to look.

If there is a way Could you possibly implement it into the plugin? as a config option?

I can, but I can't test it atm 😭

I can test for you, if you have discord we can communicate through there aswell

XyloFD2 commented 6 months ago

My discord is xylofd if you wanna add me