fix(settings): Adds a field in the settings to edit the operators name #97

minimalchat / operator-app

Cross-platform operator application for Minimal Chat

https://minimal.chat

BSD 3-Clause "New" or "Revised" License

43 stars 7 forks source link

fix(settings): Adds a field in the settings to edit the operators name #97 #105

Closed satyamyadav closed 5 years ago

satyamyadav commented 5 years ago

Description

Adds a input field in the settings panel to change operator name, updates it in config.json and store on change event of the input box. #97

Motivation

currently the operator name is static Steve in template.

Changes

updated operator settings menu component to use operator name from props
added a input box to input name and passed its value to existing handler changeSettings

satyamyadav commented 5 years ago

@mihok I will update the PR with suggested changes. Should I add some more padding on settings panel body as label and inputs will have lot of white space in between ?

mihok commented 5 years ago

@satyamyadav that is a good thought, maybe we could leverage flex-grow here? I played with setting the first div with flex-grow: 3 and the input div to flex-grow: 2

The PR looks just about ready to be merged!

satyamyadav commented 5 years ago

@mihok I have update PR with the changes in label and input with flex-grow: 3 and flex grow: 2, also updated styles for operator name and avatar alignment, please review changes.