search

minimaxir / download-tweets-ai-text-gen

Python script to download public Tweets from a given Twitter account into a format suitable for AI text generation.
MIT License
219 stars 41 forks source link

Restoring Multiple Account Download in Master #22

Open YazzyYaz opened 4 years ago

YazzyYaz commented 4 years ago

Hi all, so I've noticed the multiple account download script doesn't work with latest master.

After digging in the code for the PR by @sdelgadoc https://github.com/minimaxir/download-tweets-ai-text-gen/pull/14 I noticed the code that was merged isn't there anymore.

There's no assert to determine if an input is a file or an account anymore. Is there any plans to restore it?

sdelgadoc commented 4 years ago

@YazzyYaz, I can confirm that the code to download multiple accounts was removed in the latest master. The README still references the functionality, and the example account files are still present, so it might be possible that it was not done on purpose.

A short term solution is to use this version of the download file: https://github.com/minimaxir/download-tweets-ai-text-gen/blob/6ee1440d7d9fa8b50b8e453d53648de5342ae104/download_tweets.py

@minimaxir, was the removal of the multiple account download purposeful? If not, happy to send a pull request bringing it back.